Skip to content

8366270: [lworld] Fix ClassFile AccessFlagsTest #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: lworld
Choose a base branch
from
Open

8366270: [lworld] Fix ClassFile AccessFlagsTest #1630

wants to merge 4 commits into from

Conversation

liach
Copy link
Member

@liach liach commented Sep 24, 2025 •
edited by openjdk bot
Loading

This is the Valhalla version of JDK-8337220.
We pass the class file version in ClassFile structures for correct access flag validation. Since we are a few tags behind there will be some merge conflict if we pull mainline.

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8366270: [lworld] Fix ClassFile AccessFlagsTest (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1630/head:pull/1630
$ git checkout pull/1630

Update a local copy of the PR:
$ git checkout pull/1630
$ git pull https://git.openjdk.org/valhalla.git pull/1630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1630

View PR using the GUI difftool:
$ git pr show -t 1630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1630.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025 •
edited
Loading

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366270: [lworld] Fix ClassFile AccessFlagsTest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 0b205d6: 8360656: [lworld] UnsafeTest.java fails with -XX:ForceNonTearable=*
  • f909731: 8366806: [lworld] JDI test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025 •
edited
Loading

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liach